> On Dec. 22, 2015, 12:45 a.m., Prasanth_J wrote: > > llap-server/src/java/org/apache/hadoop/hive/llap/cache/BufferUsageManager.java, > > line 26 > > <https://reviews.apache.org/r/41102/diff/1/?file=1156347#file1156347line26> > > > > Interface audience + javadoc?
interface audiences are not used in LLAP IO so far... added the javadoc > On Dec. 22, 2015, 12:45 a.m., Prasanth_J wrote: > > llap-server/src/java/org/apache/hadoop/hive/llap/cache/SimpleAllocator.java, > > line 47 > > <https://reviews.apache.org/r/41102/diff/1/?file=1156352#file1156352line47> > > > > How frequently is this called? If it is called frequently, then cost of > > allocateDirect() will be very high as direct allocation will sleep for > > 100ms when reserving direct memory. Such as life if you don't use the recommended settings :P > On Dec. 22, 2015, 12:45 a.m., Prasanth_J wrote: > > llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapIoImpl.java, > > line 124 > > <https://reviews.apache.org/r/41102/diff/1/?file=1156356#file1156356line124> > > > > Shouldn't this be other way? If useAllocOnly is true then we use > > SimpleAllocator without cache right? No; updated the HiveConf description to be more clear > On Dec. 22, 2015, 12:45 a.m., Prasanth_J wrote: > > llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java, > > line 620 > > <https://reviews.apache.org/r/41102/diff/1/?file=1156358#file1156358line620> > > > > Whis is this outside if condition? Can you put this all inside a single > > if not null condition? eh? We don't count cache hits or misses if there's no cache or the item is not cacheable. Added an else for clarity, this relied on return before - Sergey ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41102/#review111559 ----------------------------------------------------------- On Dec. 8, 2015, 9:20 p.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41102/ > ----------------------------------------------------------- > > (Updated Dec. 8, 2015, 9:20 p.m.) > > > Review request for hive and Prasanth_J. > > > Repository: hive-git > > > Description > ------- > > see jira > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java d52f994 > data/conf/hive-site.xml 2ebb1c4 > data/conf/llap/hive-site.xml 9440611 > llap-server/src/java/org/apache/hadoop/hive/llap/cache/BuddyAllocator.java > 0c96efa > > llap-server/src/java/org/apache/hadoop/hive/llap/cache/BufferUsageManager.java > PRE-CREATION > llap-server/src/java/org/apache/hadoop/hive/llap/cache/LowLevelCache.java > b17edb5 > > llap-server/src/java/org/apache/hadoop/hive/llap/cache/LowLevelCacheImpl.java > c2a130a > > llap-server/src/java/org/apache/hadoop/hive/llap/cache/LowLevelCacheMemoryManager.java > 8788e15 > > llap-server/src/java/org/apache/hadoop/hive/llap/cache/LowLevelLrfuCachePolicy.java > 40cb92d > llap-server/src/java/org/apache/hadoop/hive/llap/cache/SimpleAllocator.java > PRE-CREATION > > llap-server/src/java/org/apache/hadoop/hive/llap/cache/SimpleBufferManager.java > PRE-CREATION > llap-server/src/java/org/apache/hadoop/hive/llap/cli/LlapServiceDriver.java > 08d573b > > llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LlapDaemon.java > dbdf571 > > llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapIoImpl.java > b38f472 > > llap-server/src/java/org/apache/hadoop/hive/llap/io/decode/OrcColumnVectorProducer.java > 259c483 > > llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java > 885acc0 > > llap-server/src/test/org/apache/hadoop/hive/llap/cache/TestBuddyAllocator.java > 6375996 > > llap-server/src/test/org/apache/hadoop/hive/llap/cache/TestLowLevelCacheImpl.java > 8324b21 > > llap-server/src/test/org/apache/hadoop/hive/llap/cache/TestLowLevelLrfuCachePolicy.java > d0abfa3 > > Diff: https://reviews.apache.org/r/41102/diff/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > >
