> On May 26, 2016, 8:08 p.m., Ashutosh Chauhan wrote: > > I think we need to make this fix only when > > HBaseSerde.HBASE_TABLE_DEFAULT_STORAGE_TYPE='string', if its binary.. we > > can push these predicates since then lexicographical comparison would be > > correct.
You are right, I did not think about this. I have done it in the new patch. > On May 26, 2016, 8:08 p.m., Ashutosh Chauhan wrote: > > hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseStorageHandler.java, > > line 601 > > <https://reviews.apache.org/r/47838/diff/1/?file=1393766#file1393766line601> > > > > I think you may use single boolean variable here and name it as > > nonEqualityPredicate We need to check whether it is e.g. key < 5 and key > 2, as we might have key < 2 and key < 5. - Jesús ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47838/#review135034 ----------------------------------------------------------- On May 25, 2016, 5:59 p.m., Jesús Camacho Rodríguez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47838/ > ----------------------------------------------------------- > > (Updated May 25, 2016, 5:59 p.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Bugs: HIVE-13831 > https://issues.apache.org/jira/browse/HIVE-13831 > > > Repository: hive-git > > > Description > ------- > > HIVE-13831 > > > Diffs > ----- > > > accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/predicate/AccumuloPredicateHandler.java > d5cc9a5491edddc4fae840e087b384587ac17ddc > > accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/predicate/PushdownTuple.java > f326d522daf694a788b7b52f23da4134bc4251e6 > > hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseStorageHandler.java > 42ea24e41883d8c02b49848020a80fcc7f179c50 > hbase-handler/src/test/results/positive/external_table_ppd.q.out > 590906b63e18c64cbadc5b02d978cbad41c8220f > hbase-handler/src/test/results/positive/hbase_pushdown.q.out > a42e36f0132457d22240d3ef4b8a52375a14fe34 > hbase-handler/src/test/results/positive/hbase_timestamp.q.out > 29a04f9167803c896f998ed75a89e8f20ef4799e > hbase-handler/src/test/results/positive/ppd_key_ranges.q.out > 34c3b230bd64f4fe9aa92a0e874e0f0a4919d208 > ql/src/java/org/apache/hadoop/hive/ql/index/IndexPredicateAnalyzer.java > 2f0deae34ac42e5f6cbfffc6148473b62fb82d0c > ql/src/java/org/apache/hadoop/hive/ql/index/IndexSearchCondition.java > 3a2ecb7282a2eed0b1f7e49ca70b15f10c8e9675 > > Diff: https://reviews.apache.org/r/47838/diff/ > > > Testing > ------- > > > Thanks, > > Jesús Camacho Rodríguez > >
