> On May 26, 2016, 8:08 p.m., Ashutosh Chauhan wrote: > > I think we need to make this fix only when > > HBaseSerde.HBASE_TABLE_DEFAULT_STORAGE_TYPE='string', if its binary.. we > > can push these predicates since then lexicographical comparison would be > > correct. > > Jesús Camacho Rodríguez wrote: > You are right, I did not think about this. I have done it in the new > patch.
I am retracting on the above; I checked with the patch of HIVE-13693 on top, and even for binary representation, open range filters do not work. Maybe even if it is the binary representation of the value, it is ending up being stored as a String in HBase. This needs further investigation, but since currently it is not working properly in any case, I think for 2.1.0 we could just restrict binary as well as string; then HIVE-13693 can go in, and we can explore this issue further in the future. - Jesús ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47838/#review135034 ----------------------------------------------------------- On May 27, 2016, 12:40 p.m., Jesús Camacho Rodríguez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47838/ > ----------------------------------------------------------- > > (Updated May 27, 2016, 12:40 p.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Bugs: HIVE-13831 > https://issues.apache.org/jira/browse/HIVE-13831 > > > Repository: hive-git > > > Description > ------- > > HIVE-13831 > > > Diffs > ----- > > > accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/predicate/AccumuloPredicateHandler.java > d5cc9a5491edddc4fae840e087b384587ac17ddc > > accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/predicate/PushdownTuple.java > f326d522daf694a788b7b52f23da4134bc4251e6 > > hbase-handler/src/java/org/apache/hadoop/hive/hbase/AbstractHBaseKeyFactory.java > 18fb5eaebd87f2f194152241b3444adc3e24c5c3 > > hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseStorageHandler.java > 42ea24e41883d8c02b49848020a80fcc7f179c50 > hbase-handler/src/test/results/positive/hbase_pushdown.q.out > a42e36f0132457d22240d3ef4b8a52375a14fe34 > hbase-handler/src/test/results/positive/hbase_timestamp.q.out > 29a04f9167803c896f998ed75a89e8f20ef4799e > hbase-handler/src/test/results/positive/ppd_key_ranges.q.out > 34c3b230bd64f4fe9aa92a0e874e0f0a4919d208 > ql/src/java/org/apache/hadoop/hive/ql/index/IndexPredicateAnalyzer.java > 2f0deae34ac42e5f6cbfffc6148473b62fb82d0c > ql/src/java/org/apache/hadoop/hive/ql/index/IndexSearchCondition.java > 3a2ecb7282a2eed0b1f7e49ca70b15f10c8e9675 > > ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveStoragePredicateHandler.java > 7d7c764f8d800d90c7b23ed61f7deb589e51627d > ql/src/java/org/apache/hadoop/hive/ql/ppd/OpProcFactory.java > 5390ba74aa40e1686d151f867dd74553aa07a1f1 > > Diff: https://reviews.apache.org/r/47838/diff/ > > > Testing > ------- > > > Thanks, > > Jesús Camacho Rodríguez > >
