> On July 1, 2016, 5:19 p.m., Szehon Ho wrote: > > beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java, line 481 > > <https://reviews.apache.org/r/49498/diff/1/?file=1434738#file1434738line481> > > > > It seems a hacky way to detect embedded mode. > > > > What do you think about doing an or, say if the command line opts is > > set, or the hive.cli.pring.current.db is in the properties file. (i guess > > now there is beeline.properties) > > Peter Vary wrote: > To tell the truth, I did not know, that there were two modes of running > beeline, until I found this type of check everywhere in the code, and finally > found it where this was set. :) See HiveCli. I will think about your > suggestions too, thanks
Thanks for your, and for Vihang's comment, I think I have a better understanding of beeline modes now. It is not embedded/remote mode which makes the difference here, but the beeline/compatibility mode. I will change the JIRA, and the comments to match this. If you think my reasoning is faulty, or I should do the changes for other modes as well, state it, and I will do my best :) - Peter ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49498/#review140385 ----------------------------------------------------------- On July 1, 2016, 3:08 p.m., Peter Vary wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49498/ > ----------------------------------------------------------- > > (Updated July 1, 2016, 3:08 p.m.) > > > Review request for hive, Sergio Pena, Szehon Ho, and Vihang Karajgaonkar. > > > Bugs: HIVE-14123 > https://issues.apache.org/jira/browse/HIVE-14123 > > > Repository: hive-git > > > Description > ------- > > There are several jira issues complaining that, the Beeline does not respect > hive.cli.print.current.db. > This is partially true, since in embedded mode, it uses the > hive.cli.print.current.db to change the prompt, since HIVE-10511. > In remote mode, I think this function should use a beeline command line > option instead, like for the showHeader option emphasizing, that this is a > client side option. > > The patch contains: > - New configuration option > - Changing the help text > - Updating command hooks, to run in remote mode as well > - Adding new hooks, for connect and go sqllite commands > - Generalize database connection refresh command > - Changing prompt > > > Diffs > ----- > > beeline/src/java/org/apache/hive/beeline/BeeLine.java 66185f6 > beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java 5aaa385 > beeline/src/java/org/apache/hive/beeline/ClientCommandHookFactory.java > c4d97bc > beeline/src/java/org/apache/hive/beeline/Commands.java 3a204c0 > beeline/src/java/org/apache/hive/beeline/ReflectiveCommandHandler.java > 3b863ae > beeline/src/main/resources/BeeLine.properties 7500df9 > beeline/src/test/org/apache/hive/beeline/TestBeelineArgParsing.java ce1f538 > beeline/src/test/org/apache/hive/beeline/TestClientCommandHookFactory.java > c86de0a > > Diff: https://reviews.apache.org/r/49498/diff/ > > > Testing > ------- > > Unit tests for the hooks, and the configuration option > > Manual test in remote, and embedded mode > > > Thanks, > > Peter Vary > >
