> On July 15, 2016, 6:04 p.m., Vihang Karajgaonkar wrote: > > Thanks for the changes. Can you please add some unit test cases?
Created extensive unit tests for ClientCommandHookFactory and the specific ClientHook-s. Created an unit test so, the prompt is checked. Do we ned more tests? Anything specific to check? Thanks, Peter > On July 15, 2016, 6:04 p.m., Vihang Karajgaonkar wrote: > > beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java, line 476 > > <https://reviews.apache.org/r/49498/diff/1/?file=1434738#file1434738line476> > > > > Can you please update the comment. Instead of remote mode vs embedded > > mode, this should talk about the behavior in cli vs beeline mode. Fixed - thanks > On July 15, 2016, 6:04 p.m., Vihang Karajgaonkar wrote: > > beeline/src/java/org/apache/hive/beeline/ClientCommandHookFactory.java, > > line 64 > > <https://reviews.apache.org/r/49498/diff/1/?file=1434739#file1434739line64> > > > > I agree that in case of go command you would probably need to query the > > db, but I think in the common case of use and connect commands it would be > > still beneficial to save that extra query call. Done as advised - Peter ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49498/#review141025 ----------------------------------------------------------- On July 19, 2016, 3:26 p.m., Peter Vary wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49498/ > ----------------------------------------------------------- > > (Updated July 19, 2016, 3:26 p.m.) > > > Review request for hive, Sergio Pena, Szehon Ho, and Vihang Karajgaonkar. > > > Bugs: HIVE-14123 > https://issues.apache.org/jira/browse/HIVE-14123 > > > Repository: hive-git > > > Description > ------- > > There are several jira issues complaining that, the Beeline does not respect > hive.cli.print.current.db. > This is partially true, since in embedded mode, it uses the > hive.cli.print.current.db to change the prompt, since HIVE-10511. > In remote mode, I think this function should use a beeline command line > option instead, like for the showHeader option emphasizing, that this is a > client side option. > > The patch contains: > - New configuration option > - Changing the help text > - Updating command hooks, to run in remote mode as well > - Adding new hooks, for connect and go sqllite commands > - Generalize database connection refresh command > - Changing prompt > > > Diffs > ----- > > beeline/pom.xml a720d08 > beeline/src/java/org/apache/hive/beeline/BeeLine.java 66185f6 > beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java 5aaa385 > beeline/src/java/org/apache/hive/beeline/ClientCommandHookFactory.java > c4d97bc > beeline/src/java/org/apache/hive/beeline/Commands.java 3a204c0 > beeline/src/java/org/apache/hive/beeline/ReflectiveCommandHandler.java > 3b863ae > beeline/src/main/resources/BeeLine.properties 7500df9 > beeline/src/test/org/apache/hive/beeline/TestBeelineArgParsing.java ce1f538 > beeline/src/test/org/apache/hive/beeline/TestClientCommandHookFactory.java > c86de0a > > itests/hive-unit/src/test/java/org/apache/hive/beeline/TestBeeLineWithArgs.java > ecfeddb > jdbc/src/java/org/apache/hive/jdbc/Utils.java 7ea6309 > > Diff: https://reviews.apache.org/r/49498/diff/ > > > Testing > ------- > > Unit tests for the hooks, and the configuration option > > Manual test in remote, and embedded mode > > > Thanks, > > Peter Vary > >
