> On July 1, 2016, 5:19 p.m., Szehon Ho wrote: > > beeline/src/java/org/apache/hive/beeline/ClientCommandHookFactory.java, > > line 64 > > <https://reviews.apache.org/r/49498/diff/1/?file=1434739#file1434739line64> > > > > Just curious, did we explore an option to parse the database from the > > 'use' command on success to avoid the wasteful extra query, or was there > > some instances that it did not work as expected? > > Peter Vary wrote: > Actually we could parse the use, and the connect commands. The use > parsing was already there, and I did the url parsing using the jdbc uri > parsing util class, but for the go command we do not have anything at hand to > use. So for keeping the code simple, I decided to use a single hook for every > command. My reasoning behind it was, that this will run only after issuing > one of the use, connrct, go commands and it is not prone to any dubious > parsing, or other errors. > > Thanks for the comments
I did the manual parsing for the use, and the connect commands, and used the query to get the current database in case of the go command - Peter ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49498/#review140385 ----------------------------------------------------------- On July 19, 2016, 3:26 p.m., Peter Vary wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49498/ > ----------------------------------------------------------- > > (Updated July 19, 2016, 3:26 p.m.) > > > Review request for hive, Sergio Pena, Szehon Ho, and Vihang Karajgaonkar. > > > Bugs: HIVE-14123 > https://issues.apache.org/jira/browse/HIVE-14123 > > > Repository: hive-git > > > Description > ------- > > There are several jira issues complaining that, the Beeline does not respect > hive.cli.print.current.db. > This is partially true, since in embedded mode, it uses the > hive.cli.print.current.db to change the prompt, since HIVE-10511. > In remote mode, I think this function should use a beeline command line > option instead, like for the showHeader option emphasizing, that this is a > client side option. > > The patch contains: > - New configuration option > - Changing the help text > - Updating command hooks, to run in remote mode as well > - Adding new hooks, for connect and go sqllite commands > - Generalize database connection refresh command > - Changing prompt > > > Diffs > ----- > > beeline/pom.xml a720d08 > beeline/src/java/org/apache/hive/beeline/BeeLine.java 66185f6 > beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java 5aaa385 > beeline/src/java/org/apache/hive/beeline/ClientCommandHookFactory.java > c4d97bc > beeline/src/java/org/apache/hive/beeline/Commands.java 3a204c0 > beeline/src/java/org/apache/hive/beeline/ReflectiveCommandHandler.java > 3b863ae > beeline/src/main/resources/BeeLine.properties 7500df9 > beeline/src/test/org/apache/hive/beeline/TestBeelineArgParsing.java ce1f538 > beeline/src/test/org/apache/hive/beeline/TestClientCommandHookFactory.java > c86de0a > > itests/hive-unit/src/test/java/org/apache/hive/beeline/TestBeeLineWithArgs.java > ecfeddb > jdbc/src/java/org/apache/hive/jdbc/Utils.java 7ea6309 > > Diff: https://reviews.apache.org/r/49498/diff/ > > > Testing > ------- > > Unit tests for the hooks, and the configuration option > > Manual test in remote, and embedded mode > > > Thanks, > > Peter Vary > >
