----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52427/#review151046 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g (line 434) <https://reviews.apache.org/r/52427/#comment219166> Could u test if the precedence is correct w.r.t the other DBMS? If you put it here, it will be lower than */-, etc. ql/src/test/queries/clientpositive/concat_op.q (line 1) <https://reviews.apache.org/r/52427/#comment219167> Could you add more tests? For example, create views, joins, gby, union, || with other operators, esp, |, *, +. - pengcheng xiong On Sept. 30, 2016, 3:08 p.m., Zoltan Haindrich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52427/ > ----------------------------------------------------------- > > (Updated Sept. 30, 2016, 3:08 p.m.) > > > Review request for hive, Ashutosh Chauhan and pengcheng xiong. > > > Repository: hive-git > > > Description > ------- > > adds support for || text concatenation > > * reuses the concat udf for doing the real work > * same precedence as + / - ; I think this is expected > * small ast rewrite code in SemanticAnalyzer > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g > b623187a788a23eceb70a71de62671ad778a24b7 > ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g > e6b70a0a0e328a27a808032857b8ecb7ecffeb64 > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java > 747f3876b76de195fea78d87bfd98bd0ec2b87a0 > ql/src/test/queries/clientpositive/concat_op.q PRE-CREATION > ql/src/test/results/clientpositive/concat_op.q.out PRE-CREATION > > Diff: https://reviews.apache.org/r/52427/diff/ > > > Testing > ------- > > > Thanks, > > Zoltan Haindrich > >
