----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52427/#review153040 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g (line 445) <https://reviews.apache.org/r/52427/#comment222302> change this to {code} precedenceConcatenateExpression : (precedencePlusExpression -> precedencePlusExpression) ( precedenceConcatenateOperator plus=precedencePlusExpression -> ^(TOK_FUNCTION {adaptor.create(Identifier, "concat")} {$precedenceConcatenateExpression.tree} $plus) )* -> {$precedenceConcatenateExpression.tree} ; {code} So that we can finish the rewriting in the parser. ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java (line 10685) <https://reviews.apache.org/r/52427/#comment222303> remove all the changes in SemanticAnalyzer. ql/src/test/queries/clientpositive/concat_op.q (line 3) <https://reviews.apache.org/r/52427/#comment222304> Please confirm that Postgres and/Oracle returns the same result. - pengcheng xiong On Oct. 13, 2016, 7:25 p.m., Zoltan Haindrich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52427/ > ----------------------------------------------------------- > > (Updated Oct. 13, 2016, 7:25 p.m.) > > > Review request for hive, Ashutosh Chauhan and pengcheng xiong. > > > Bugs: HIVE-14580 > https://issues.apache.org/jira/browse/HIVE-14580 > > > Repository: hive-git > > > Description > ------- > > adds support for || text concatenation > > * reuses the concat udf for doing the real work > * same precedence as + / - ; I think this is expected > * small ast rewrite code in SemanticAnalyzer > * details about other db || operators: > https://issues.apache.org/jira/browse/HIVE-14580?focusedCommentId=15546578&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15546578 > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g > 025ea10cda5b126f46226809884088caadc0a3d0 > ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g > 13f68796e4fe262098eaf6c5f09bc7f963d0f8cf > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java > 747f3876b76de195fea78d87bfd98bd0ec2b87a0 > ql/src/test/queries/clientpositive/concat_op.q PRE-CREATION > ql/src/test/results/clientpositive/concat_op.q.out PRE-CREATION > > Diff: https://reviews.apache.org/r/52427/diff/ > > > Testing > ------- > > added qtest > > > Thanks, > > Zoltan Haindrich > >
