-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52427/
-----------------------------------------------------------

(Updated Oct. 13, 2016, 7:25 p.m.)


Review request for hive, Ashutosh Chauhan and pengcheng xiong.


Changes
-------

added some more tests...group by / order by


Bugs: HIVE-14580
    https://issues.apache.org/jira/browse/HIVE-14580


Repository: hive-git


Description
-------

adds support for || text concatenation

* reuses the concat udf for doing the real work
* same precedence as + / - ; I think this is expected
* small ast rewrite code in SemanticAnalyzer
* details about other db || operators: 
https://issues.apache.org/jira/browse/HIVE-14580?focusedCommentId=15546578&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15546578


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g 
025ea10cda5b126f46226809884088caadc0a3d0 
  ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g 
13f68796e4fe262098eaf6c5f09bc7f963d0f8cf 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 
747f3876b76de195fea78d87bfd98bd0ec2b87a0 
  ql/src/test/queries/clientpositive/concat_op.q PRE-CREATION 
  ql/src/test/results/clientpositive/concat_op.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/52427/diff/


Testing
-------

added qtest


Thanks,

Zoltan Haindrich

Reply via email to