> On Feb. 18, 2017, 11:17 p.m., Vihang Karajgaonkar wrote: > > itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreBeeLineDriver.java, > > line 116 > > <https://reviews.apache.org/r/52978/diff/3/?file=1541464#file1541464line116> > > > > Having a fixed port number could become a problem in ptests. May be we > > should use a port number which is available in the run time (I think > > miniHS2 instantiates on a available port at the run time) > > Peter Vary wrote: > As above :)
We can do it in another JIRA as well. My guess is that if we use fixed ports it is more likely that this test will fail when we run it in pre-commit job due to parallel execution of batches. - Vihang ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52978/#review166031 ----------------------------------------------------------- On Oct. 19, 2016, 1:39 p.m., Peter Vary wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52978/ > ----------------------------------------------------------- > > (Updated Oct. 19, 2016, 1:39 p.m.) > > > Review request for hive, Zoltan Haindrich, Marta Kuczora, Miklos Csanady, > Prasanth_J, Sergey Shelukhin, Sergio Pena, Siddharth Seth, and Barna Zsombor > Klara. > > > Bugs: HIVE-14459 > https://issues.apache.org/jira/browse/HIVE-14459 > > > Repository: hive-git > > > Description > ------- > > Kept the changes minimal with the sole goal to be able to run the BeeLine > query tests multiple times successfully. > - Enabled the driver > - Modified the regexps to hide when comparing the results > - Configured to run only 1 qtest file - so we can test, and could decide > later of the beeline testing scope > - Added required dependencies to pom > - Added specific results dir for beeline q.out-s > > > Diffs > ----- > > beeline/src/java/org/apache/hive/beeline/util/QFileClient.java 81f1b0e > > itests/qtest/src/test/java/org/apache/hadoop/hive/cli/DisabledTestBeeLineDriver.java > cb276e6 > > itests/qtest/src/test/java/org/apache/hadoop/hive/cli/TestBeeLineDriver.java > PRE-CREATION > itests/src/test/resources/testconfiguration.properties 97e310d > itests/util/pom.xml 6d93dc1 > > itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CliConfigs.java > 366c7b4 > > itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreBeeLineDriver.java > e5144e3 > ql/src/test/results/clientpositive/beeline/escape_comments.q.out > PRE-CREATION > > Diff: https://reviews.apache.org/r/52978/diff/ > > > Testing > ------- > > Manually on my computer several runs. > Waiting for the QA tests > > > Thanks, > > Peter Vary > >
