----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52978/#review166945 -----------------------------------------------------------
LGTM (non-binding). Just one comment below. Thanks Peter! itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreBeeLineDriver.java (line 76) <https://reviews.apache.org/r/52978/#comment239036> we should probably use cleanupLocalDirOnStartup(true) here. As a part of fixing flaky tests work, this flag was set to true for the other tests - Vihang Karajgaonkar On Feb. 24, 2017, 12:21 p.m., Peter Vary wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52978/ > ----------------------------------------------------------- > > (Updated Feb. 24, 2017, 12:21 p.m.) > > > Review request for hive, Zoltan Haindrich, Marta Kuczora, Miklos Csanady, > Prasanth_J, Sergey Shelukhin, Sergio Pena, Siddharth Seth, and Barna Zsombor > Klara. > > > Bugs: HIVE-14459 > https://issues.apache.org/jira/browse/HIVE-14459 > > > Repository: hive-git > > > Description > ------- > > Kept the changes minimal with the sole goal to be able to run the BeeLine > query tests multiple times successfully. > - Enabled the driver > - Modified the regexps to hide when comparing the results > - Configured to run only 1 qtest file - so we can test, and could decide > later of the beeline testing scope > - Added required dependencies to pom > - Added specific results dir for beeline q.out-s > > > Diffs > ----- > > beeline/src/java/org/apache/hive/beeline/util/QFileClient.java 81f1b0e > > itests/hive-unit/src/main/java/org/apache/hive/jdbc/miniHS2/AbstractHiveService.java > > itests/hive-unit/src/main/java/org/apache/hive/jdbc/miniHS2/MiniHS2.java > > itests/qtest/src/test/java/org/apache/hadoop/hive/cli/DisabledTestBeeLineDriver.java > cb276e6 > itests/src/test/resources/testconfiguration.properties d344464 > itests/util/pom.xml 6d93dc1 > > itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CliConfigs.java > af8ec67 > > itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreBeeLineDriver.java > e5144e3 > ql/src/test/results/clientpositive/beeline/escape_comments.q.out > PRE-CREATION > > Diff: https://reviews.apache.org/r/52978/diff/ > > > Testing > ------- > > Manually on my computer several runs. > Waiting for the QA tests > > > Thanks, > > Peter Vary > >
