----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63586/#review190457 -----------------------------------------------------------
Ship it! LGTM. Thanks for the changes! itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStoreAlterColumnPar.java Lines 94 (patched) <https://reviews.apache.org/r/63586/#comment267837> I looked up online I think a better way to do this would be Assert.fail("Exception not thrown"), but this works too. - Vihang Karajgaonkar On Nov. 7, 2017, 9:19 p.m., Janaki Lahorani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63586/ > ----------------------------------------------------------- > > (Updated Nov. 7, 2017, 9:19 p.m.) > > > Review request for hive, Alexander Kolbasov, Andrew Sherman, Sahil Takiar, > and Vihang Karajgaonkar. > > > Repository: hive-git > > > Description > ------- > > HMS handler thread local will have the configuration changes from the user > local only to that connection. HiveAlterHandler should use the thread local > to pick up user's configuration changes. > > > Diffs > ----- > > > itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStoreAlterColumnPar.java > PRE-CREATION > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java > ccadac1ada6aaae884ab39f5d99e91b8c542404e > > > Diff: https://reviews.apache.org/r/63586/diff/3/ > > > Testing > ------- > > > Thanks, > > Janaki Lahorani > >
