> On Nov. 8, 2017, 5:03 p.m., Andrew Sherman wrote: > > itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStoreAlterColumnPar.java > > Lines 107 (patched) > > <https://reviews.apache.org/r/63586/diff/3/?file=1884157#file1884157line107> > > > > It is generally tidier to use the try-with-resources to close > > statements and connections. Older code doesn't always use this but we > > should probably make new code use it whenever possible.
Thanks Andrew. I changed it to do try-with-resources. I will be grateful if you can take a look. - Janaki ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63586/#review190454 ----------------------------------------------------------- On Nov. 8, 2017, 7:17 p.m., Janaki Lahorani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63586/ > ----------------------------------------------------------- > > (Updated Nov. 8, 2017, 7:17 p.m.) > > > Review request for hive, Alexander Kolbasov, Andrew Sherman, Sahil Takiar, > and Vihang Karajgaonkar. > > > Repository: hive-git > > > Description > ------- > > HMS handler thread local will have the configuration changes from the user > local only to that connection. HiveAlterHandler should use the thread local > to pick up user's configuration changes. > > > Diffs > ----- > > > itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStoreAlterColumnPar.java > PRE-CREATION > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java > 921cfc00343807179340fbdf40f21e2a46d936ab > > > Diff: https://reviews.apache.org/r/63586/diff/4/ > > > Testing > ------- > > > Thanks, > > Janaki Lahorani > >
