----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65018/ -----------------------------------------------------------
(Updated Jan. 9, 2018, 2:50 p.m.) Review request for hive, Alan Gates, Marta Kuczora, Adam Szita, and Vihang Karajgaonkar. Changes ------- Addressing Marta's comments Bugs: HIVE-18372 https://issues.apache.org/jira/browse/HIVE-18372 Repository: hive-git Description ------- Created: - AbstractMetastore class - to privide an interface for different metastore implementation (start/stop/warehouse path methods) -- Implementation for Embedded/Remote/Cluster metastores - MiniHMS with builder - to create hms instances for test - MetaStoreFactory - to create the parameter list for parametrized test - TestDatabases - test for database related metastore functions to showcase the infrastructure Diffs (updated) ----- standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/MetaStoreFactory.java PRE-CREATION standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestDatabases.java PRE-CREATION standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/minihms/AbstractMetaStoreService.java PRE-CREATION standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/minihms/ClusterMetaStore.java PRE-CREATION standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/minihms/EmbeddedMetaStore.java PRE-CREATION standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/minihms/MiniHMS.java PRE-CREATION standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/minihms/RemoteMetaStore.java PRE-CREATION Diff: https://reviews.apache.org/r/65018/diff/2/ Changes: https://reviews.apache.org/r/65018/diff/1-2/ Testing ------- Run the new tests Thanks, Peter Vary