----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65018/#review195114 -----------------------------------------------------------
standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/MetaStoreFactory.java Lines 32 (patched) <https://reviews.apache.org/r/65018/#comment274255> If this is used for testing only I would suggest renaming it to something like MetaStoreFactoryForTests so that it is clear. Same for the other new classes introduced namely, [Cluster|Embedded|Remote]Metastore.java standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestDatabases.java Lines 52 (patched) <https://reviews.apache.org/r/65018/#comment274256> Parameterized tests don't work well in Ptest since it is cannot be parallelized. I would suggest creating a Abstract base class with all the tests and creating subclasses for remote and embedded like we have for TestHiveMetaStore test currently. - Vihang Karajgaonkar On Jan. 9, 2018, 2:50 p.m., Peter Vary wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65018/ > ----------------------------------------------------------- > > (Updated Jan. 9, 2018, 2:50 p.m.) > > > Review request for hive, Alan Gates, Marta Kuczora, Adam Szita, and Vihang > Karajgaonkar. > > > Bugs: HIVE-18372 > https://issues.apache.org/jira/browse/HIVE-18372 > > > Repository: hive-git > > > Description > ------- > > Created: > - AbstractMetastore class - to privide an interface for different metastore > implementation (start/stop/warehouse path methods) > -- Implementation for Embedded/Remote/Cluster metastores > - MiniHMS with builder - to create hms instances for test > - MetaStoreFactory - to create the parameter list for parametrized test > - TestDatabases - test for database related metastore functions to showcase > the infrastructure > > > Diffs > ----- > > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/MetaStoreFactory.java > PRE-CREATION > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestDatabases.java > PRE-CREATION > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/minihms/AbstractMetaStoreService.java > PRE-CREATION > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/minihms/ClusterMetaStore.java > PRE-CREATION > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/minihms/EmbeddedMetaStore.java > PRE-CREATION > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/minihms/MiniHMS.java > PRE-CREATION > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/minihms/RemoteMetaStore.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/65018/diff/2/ > > > Testing > ------- > > Run the new tests > > > Thanks, > > Peter Vary > >
