> On Jan. 10, 2018, 3:35 a.m., Vihang Karajgaonkar wrote: > >
Thanks for the review Vihang! > On Jan. 10, 2018, 3:35 a.m., Vihang Karajgaonkar wrote: > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestDatabases.java > > Lines 52 (patched) > > <https://reviews.apache.org/r/65018/diff/2/?file=1937641#file1937641line52> > > > > Parameterized tests don't work well in Ptest since it is cannot be > > parallelized. I would suggest creating a Abstract base class with all the > > tests and creating subclasses for remote and embedded like we have for > > TestHiveMetaStore test currently. TestHiveMetaStore currently has 5 subclasses (TestEmbeddedHiveMetaStore, TestRemoteHiveMetaStore, TestSetUGIOnBothClientServer, TestSetUGIOnOnlyClient, TestSetUGIOnOnlyServer) running the same tests against different configurations. This class is a huge one which should be split, but spliting would mean to multiple the test classes 5 times. That is why I think it is better to do this way. If we will have timing concerns then we still can split the test cases more. What do you think? - Peter ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65018/#review195114 ----------------------------------------------------------- On Jan. 10, 2018, 3:44 p.m., Peter Vary wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65018/ > ----------------------------------------------------------- > > (Updated Jan. 10, 2018, 3:44 p.m.) > > > Review request for hive, Alan Gates, Marta Kuczora, Adam Szita, and Vihang > Karajgaonkar. > > > Bugs: HIVE-18372 > https://issues.apache.org/jira/browse/HIVE-18372 > > > Repository: hive-git > > > Description > ------- > > Created: > - AbstractMetastore class - to privide an interface for different metastore > implementation (start/stop/warehouse path methods) > -- Implementation for Embedded/Remote/Cluster metastores > - MiniHMS with builder - to create hms instances for test > - MetaStoreFactory - to create the parameter list for parametrized test > - TestDatabases - test for database related metastore functions to showcase > the infrastructure > > > Diffs > ----- > > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/MetaStoreFactoryForTests.java > PRE-CREATION > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestDatabases.java > PRE-CREATION > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/minihms/AbstractMetaStoreService.java > PRE-CREATION > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/minihms/ClusterMetaStoreForTests.java > PRE-CREATION > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/minihms/EmbeddedMetaStoreForTests.java > PRE-CREATION > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/minihms/MiniHMS.java > PRE-CREATION > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/minihms/RemoteMetaStoreForTests.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/65018/diff/3/ > > > Testing > ------- > > Run the new tests > > > Thanks, > > Peter Vary > >