+1 to running automated tests whenever a patch introduces schema changes. This could act as safeguard in case a contributor forget to run these tests. I think the extra running time is worth the testing in this case.
Vineet > On Feb 13, 2018, at 3:48 PM, Vihang Karajgaonkar <vih...@cloudera.com> wrote: > > We used to have a job which ran some tests when there were schema changes > in the patch. It ran scripts from testutils/metastore to setup and run some > basic validation checks (primarily to detect incompatible schema changes > and schema upgrades). I think we should run similar tests whenever schema > changes are introduced in a patch. Currently, there is no automated testing > for schema changes. At the very least it helps catching simple syntax > errors in the schema patches. > > On Tue, Feb 13, 2018 at 3:15 PM, Alan Gates <alanfga...@gmail.com> wrote: > >> They aren’t currently. I don’t know if we want to add them as part of it >> or not. They take a little while to run in a fresh environment like the >> precommit testing because they have to download the docker images. The >> Oracle one is 2.4G. We can set it up to do it if we want to. Or maybe we >> could set it up so they only run if a change is made to the install or >> upgrade scripts. >> >> Alan. >> >> On Tue, Feb 13, 2018 at 2:43 PM, Vineet Garg <vg...@hortonworks.com> >> wrote: >> >>> Hi Alan, >>> >>> Will these tests be run as part of pre commit testing job? >>> >>> Thanks, >>> Vineet G >>> >>>> On Feb 12, 2018, at 9:56 AM, Alan Gates <alanfga...@gmail.com> wrote: >>>> >>>> With the commit of HIVE-17983 to master there are now tests for install >>> and >>>> upgrade scripts for the metastore database for all 4 of the database >>> types >>>> (mysql, postgres, oracle, and sql server). These are not run by >> default >>> as >>>> they take a bit and require docker to be installed on the box. For >>>> instructions on how to run them see standalone-metastore/DEV-README. >>>> >>>> If you are making changes to the database scripts, please run these >>> before >>>> commit. >>>> >>>> Alan. >>> >>> >>
