> On Oct. 18, 2018, 2:33 p.m., Karthik Manamcheri wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java > > Line 244 (original), 341 (patched) > > <https://reviews.apache.org/r/69054/diff/2/?file=2098740#file2098740line347> > > > > You are ignoring the return value? Should you have > > pmf=getUpdatedPmfIfNeeded(..)? > > Vihang Karajgaonkar wrote: > The pmf is updated by the method if needed, so we don't need to use the > return value. Will rename the method to updatePmfIfNeeded to make it more > readable. > > Karthik Manamcheri wrote: > And you can have it has void return.
comment does not apply to latest version of the patch. Dropping it. > On Oct. 18, 2018, 2:33 p.m., Karthik Manamcheri wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java > > Line 287 (original), 374 (patched) > > <https://reviews.apache.org/r/69054/diff/2/?file=2098740#file2098740line390> > > > > What is dss.log? Actually, I don't know what it is. Looking at the git history, this line has been there forever. Looks like its about time to update it :) - Vihang ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69054/#review209742 ----------------------------------------------------------- On Nov. 1, 2018, 8:48 p.m., Vihang Karajgaonkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69054/ > ----------------------------------------------------------- > > (Updated Nov. 1, 2018, 8:48 p.m.) > > > Review request for hive, Andrew Sherman, Alan Gates, and Peter Vary. > > > Bugs: HIVE-20740 > https://issues.apache.org/jira/browse/HIVE-20740 > > > Repository: hive-git > > > Description > ------- > > HIVE-20740 : Remove global lock in ObjectStore.setConf method > > > Diffs > ----- > > > itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/TestReplicationScenarios.java > 75cd68a9d6be6c5804e458d19a0023f0d7f5beae > > itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcWithMiniHS2.java > 5cb0a887e672f49739f5b648e608fba66de06326 > ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java > ee7c940d2b7fbd66af2d006da0585c6b42b9b0bb > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java > 03e3a2d2573b54651833867b906821650f4fb9c1 > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/PersistenceManagerProvider.java > PRE-CREATION > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestObjectStore.java > b74c3048fa2e18adc7f0d7cc813a180d4466fa36 > > > Diff: https://reviews.apache.org/r/69054/diff/5/ > > > Testing > ------- > > > Thanks, > > Vihang Karajgaonkar > >
