----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69054/#review209742 -----------------------------------------------------------
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java Line 244 (original), 341 (patched) <https://reviews.apache.org/r/69054/#comment294296> You are ignoring the return value? Should you have pmf=getUpdatedPmfIfNeeded(..)? standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java Line 287 (original), 374 (patched) <https://reviews.apache.org/r/69054/#comment294297> What is dss.log? standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestObjectStore.java Lines 927 (patched) <https://reviews.apache.org/r/69054/#comment294298> Is this testing the new read/write lock behavior? As in, would this test have failed if you had the previous behavior of a global lock? - Karthik Manamcheri On Oct. 16, 2018, 10:47 p.m., Vihang Karajgaonkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69054/ > ----------------------------------------------------------- > > (Updated Oct. 16, 2018, 10:47 p.m.) > > > Review request for hive, Andrew Sherman, Alan Gates, and Peter Vary. > > > Bugs: HIVE-20740 > https://issues.apache.org/jira/browse/HIVE-20740 > > > Repository: hive-git > > > Description > ------- > > HIVE-20740 : Remove global lock in ObjectStore.setConf method > > > Diffs > ----- > > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java > 66977d79c946f1ac57aacfbe8704d37bfbac3ea3 > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestObjectStore.java > b74c3048fa2e18adc7f0d7cc813a180d4466fa36 > > > Diff: https://reviews.apache.org/r/69054/diff/2/ > > > Testing > ------- > > > Thanks, > > Vihang Karajgaonkar > >
