----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69054/#review210911 -----------------------------------------------------------
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/PersistenceManagerProvider.java Lines 162 (patched) <https://reviews.apache.org/r/69054/#comment295739> Should we acquire the writeLock before releasing the readLock to prevent another thread from entering this code? This way we dont have to re-check these as well if (prop == null || pmf == null || !propsFromConf.equals(prop)) - Naveen Gangam On Nov. 27, 2018, 7:18 a.m., Vihang Karajgaonkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69054/ > ----------------------------------------------------------- > > (Updated Nov. 27, 2018, 7:18 a.m.) > > > Review request for hive, Andrew Sherman, Alan Gates, and Peter Vary. > > > Bugs: HIVE-20740 > https://issues.apache.org/jira/browse/HIVE-20740 > > > Repository: hive-git > > > Description > ------- > > HIVE-20740 : Remove global lock in ObjectStore.setConf method > > > Diffs > ----- > > > itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/TestReplicationScenarios.java > 5a88550f0625a7ec1890df7f54e7fa579f58fff4 > > itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcWithMiniHS2.java > 5cb0a887e672f49739f5b648e608fba66de06326 > ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java > 455ffc3887e62fa503cc3fa28255702ea9da3cc0 > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java > 570281b54fa236d5bb568b4ded9b166ef367f613 > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/PersistenceManagerProvider.java > PRE-CREATION > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestObjectStore.java > af9efd98ea210335c6ac1d3da8624e02aadc2706 > > > Diff: https://reviews.apache.org/r/69054/diff/6/ > > > Testing > ------- > > > Thanks, > > Vihang Karajgaonkar > >
