[ 
https://issues.apache.org/jira/browse/HIVE-4874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13710604#comment-13710604
 ] 

Edward Capriolo commented on HIVE-4874:
---------------------------------------

Also comes with the obligatory re-implmentation of string join alternative :)

{code}
    for (int i = 0; i < fields.size(); i++)
    {
      cNames.append(i > 0 ? "," : "");
      cTypes.append(i > 0 ? "," : "");
      cNames.append(columnNames.get(i));
      cTypes.append(fields.get(i).getTypeName());
    }
{code}
                
> Identical methods PTFDeserializer.addOIPropertiestoSerDePropsMap(), 
> PTFTranslator.addOIPropertiestoSerDePropsMap()
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-4874
>                 URL: https://issues.apache.org/jira/browse/HIVE-4874
>             Project: Hive
>          Issue Type: Improvement
>          Components: PTF-Windowing
>            Reporter: Jason Dere
>            Priority: Minor
>
> The following static methods look completely identical:
>   PTFDeserializer.addOIPropertiestoSerDePropsMap()
>   PTFTranslator.addOIPropertiestoSerDePropsMap()
> They can probably be refactored to a common methods that both classes use.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to