[ https://issues.apache.org/jira/browse/HIVE-4874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13712396#comment-13712396 ]
Hive QA commented on HIVE-4874: ------------------------------- {color:green}Overall{color}: +1 all checks pass Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12592918/HIVE-4874.patch.txt {color:green}SUCCESS:{color} +1 all tests passed Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/77/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/77/console Messages: Executing org.apache.hive.ptest.execution.CleanupPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase This message is automatically generated. > Identical methods PTFDeserializer.addOIPropertiestoSerDePropsMap(), > PTFTranslator.addOIPropertiestoSerDePropsMap() > ------------------------------------------------------------------------------------------------------------------ > > Key: HIVE-4874 > URL: https://issues.apache.org/jira/browse/HIVE-4874 > Project: Hive > Issue Type: Improvement > Components: PTF-Windowing > Reporter: Jason Dere > Assignee: Edward Capriolo > Priority: Minor > Fix For: 0.12.0 > > Attachments: HIVE-4874.patch.txt > > > The following static methods look completely identical: > PTFDeserializer.addOIPropertiestoSerDePropsMap() > PTFTranslator.addOIPropertiestoSerDePropsMap() > They can probably be refactored to a common methods that both classes use. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira