[ https://issues.apache.org/jira/browse/HIVE-4874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13712036#comment-13712036 ]
Edward Capriolo commented on HIVE-4874: --------------------------------------- Created patch. Did not create a new class for now, just had one class reference the other. Also created a new ticket for style cleanup of the PTF. > Identical methods PTFDeserializer.addOIPropertiestoSerDePropsMap(), > PTFTranslator.addOIPropertiestoSerDePropsMap() > ------------------------------------------------------------------------------------------------------------------ > > Key: HIVE-4874 > URL: https://issues.apache.org/jira/browse/HIVE-4874 > Project: Hive > Issue Type: Improvement > Components: PTF-Windowing > Reporter: Jason Dere > Assignee: Edward Capriolo > Priority: Minor > Fix For: 0.12.0 > > Attachments: HIVE-4874.patch.txt > > > The following static methods look completely identical: > PTFDeserializer.addOIPropertiestoSerDePropsMap() > PTFTranslator.addOIPropertiestoSerDePropsMap() > They can probably be refactored to a common methods that both classes use. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira