[ 
https://issues.apache.org/jira/browse/HIVE-5402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13786640#comment-13786640
 ] 

Ashutosh Chauhan commented on HIVE-5402:
----------------------------------------

* Your explanation of that variable confuses me further. Seems, like this code 
can be refactored for not needing to know such finer details about from which 
class it was called from. Seems like brittle code. We should explore this more 
in another jira, otherwise plethora of these booleans makes code very hard to 
understand since it now results in very tight coupling of state in different 
classes.

* You got me :) Here also getConf() should return HiveConf, if that touches too 
many files, its ok to do cast for now, but in another jira we need to refactor 
this too.

> StorageBasedAuthorizationProvider is not correctly able to determine that it 
> is running from client-side
> --------------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-5402
>                 URL: https://issues.apache.org/jira/browse/HIVE-5402
>             Project: Hive
>          Issue Type: Bug
>          Components: Authorization
>            Reporter: Sushanth Sowmyan
>            Assignee: Sushanth Sowmyan
>         Attachments: HIVE-5402.2.patch, HIVE-5402.patch
>
>
> HIVE-5048 tried to change the StorageBasedAuthorizationProvider (SBAP) so 
> that it could be run from the client side as well.
> However, there is a bug that causes SBAP to incorrectly conclude that it's 
> running from the metastore-side when it's actually running from the 
> client-side that causes it to throw a IllegalStateException claiming the 
> warehouse variable isn't set.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to