----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14523/#review26797 -----------------------------------------------------------
Hi Prasad, I think this is a good change. There is one item below that might need resolving? service/src/java/org/apache/hive/service/cli/CLIService.java <https://reviews.apache.org/r/14523/#comment52139> userVars contains /** * The conf variables that depends on current user */ public static final HiveConf.ConfVars[] userVars = { HiveConf.ConfVars.SCRATCHDIR, HiveConf.ConfVars.LOCALSCRATCHDIR, HiveConf.ConfVars.DOWNLOADED_RESOURCES_DIR, HiveConf.ConfVars.HIVEHISTORYFILELOC }; Do the other two need to be configured as well? service/src/java/org/apache/hive/service/cli/session/HiveSessionImplwithUGI.java <https://reviews.apache.org/r/14523/#comment52140> userVars is unused after this change. - Brock Noland On Oct. 8, 2013, 1:34 a.m., Prasad Mujumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14523/ > ----------------------------------------------------------- > > (Updated Oct. 8, 2013, 1:34 a.m.) > > > Review request for hive. > > > Bugs: HIVE-5486 > https://issues.apache.org/jira/browse/HIVE-5486 > > > Repository: hive-git > > > Description > ------- > > With impersonation enabled, the same base directory is used by all > sessions/queries. For a new deployment, this directory gets created on first > invocation by the user running that session. This would cause directory > permission conflict for other users. > The patch is creating base scratch dirs at startup if it doesn't exist. > > > Diffs > ----- > > service/src/java/org/apache/hive/service/cli/CLIService.java 1a7f338 > > service/src/java/org/apache/hive/service/cli/session/HiveSessionImplwithUGI.java > ae7bb6b > > service/src/test/org/apache/hive/service/cli/TestEmbeddedThriftBinaryCLIService.java > da325da > service/src/test/org/apache/hive/service/cli/TestScratchDir.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/14523/diff/ > > > Testing > ------- > > Added new test > > > Thanks, > > Prasad Mujumdar > >
