> On Oct. 17, 2013, 2:05 a.m., Thejas Nair wrote: > >
Addressed the suggestions. will rebase and upload the new patch. > On Oct. 17, 2013, 2:05 a.m., Thejas Nair wrote: > > service/src/java/org/apache/hive/service/cli/CLIService.java, line 94 > > <https://reviews.apache.org/r/14523/diff/3/?file=362770#file362770line94> > > > > This can lead to a misleading error message. I think it is better to > > have two try-catch blocks. > > Make sense. Done. > On Oct. 17, 2013, 2:05 a.m., Thejas Nair wrote: > > service/src/test/org/apache/hive/service/cli/TestScratchDir.java, line 37 > > <https://reviews.apache.org/r/14523/diff/3/?file=362773#file362773line37> > > > > Thanks for adding a test case! > > > > Can you change "/tmp" to System.getProperty("test.tmp.dir"); ? > > > > Even better would be to also rename "foobar" to "TestScratchDirs_foobar" > > > > It looks straightforward to add check for other two configured dirs. > > Can you include them as well ? Done. - Prasad ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14523/#review27105 ----------------------------------------------------------- On Oct. 9, 2013, 6:34 a.m., Prasad Mujumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14523/ > ----------------------------------------------------------- > > (Updated Oct. 9, 2013, 6:34 a.m.) > > > Review request for hive. > > > Bugs: HIVE-5486 > https://issues.apache.org/jira/browse/HIVE-5486 > > > Repository: hive-git > > > Description > ------- > > With impersonation enabled, the same base directory is used by all > sessions/queries. For a new deployment, this directory gets created on first > invocation by the user running that session. This would cause directory > permission conflict for other users. > The patch is creating base scratch dirs at startup if it doesn't exist. > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java d0895e1 > service/src/java/org/apache/hive/service/cli/CLIService.java 1a7f338 > > service/src/java/org/apache/hive/service/cli/session/HiveSessionImplwithUGI.java > ae7bb6b > > service/src/test/org/apache/hive/service/cli/TestEmbeddedThriftBinaryCLIService.java > da325da > service/src/test/org/apache/hive/service/cli/TestScratchDir.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/14523/diff/ > > > Testing > ------- > > Added new test > > > Thanks, > > Prasad Mujumdar > >
