----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25575/#review53376 -----------------------------------------------------------
Looks great!! I have a few comments. beeline/src/java/org/apache/hive/beeline/Commands.java <https://reviews.apache.org/r/25575/#comment93025> Let's make this 1 second. beeline/src/java/org/apache/hive/beeline/Commands.java <https://reviews.apache.org/r/25575/#comment93021> I think the + 100000 portion needs to be a constant. Let's make that a large number, like 30 minutes. jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java <https://reviews.apache.org/r/25575/#comment93022> 1) let's not import * 2) remove x_xbitmap jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java <https://reviews.apache.org/r/25575/#comment93023> Used internally can be private - Brock Noland On Sept. 12, 2014, 7:26 a.m., Dong Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25575/ > ----------------------------------------------------------- > > (Updated Sept. 12, 2014, 7:26 a.m.) > > > Review request for hive. > > > Repository: hive-git > > > Description > ------- > > When executing query in Beeline, user should have a option to see the > progress through the outputs. Beeline could use the API introduced in > HIVE-4629 to get and display the logs to the client. > > > Diffs > ----- > > beeline/pom.xml 45fa02b > beeline/src/java/org/apache/hive/beeline/Commands.java a92d69f > > itests/hive-unit/src/test/java/org/apache/hive/beeline/TestBeeLineWithArgs.java > e1d44ec > itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java > ae128a9 > jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java 2cbf58c > > Diff: https://reviews.apache.org/r/25575/diff/ > > > Testing > ------- > > UT passed. > > > Thanks, > > Dong Chen > >
