> On Sept. 18, 2014, 8:07 a.m., Thejas Nair wrote: > > jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java, line 98 > > <https://reviews.apache.org/r/25575/diff/4/?file=693372#file693372line98> > > > > Looks like we just need to check isRunning (ie true or false) for > > running. > > We don't need the whole set of enums, and complexity associated with > > getting those values right. > > Can we just use a boolean instead of the enum ? > > > > Apart from complexity, the reason for using boolean instead of enum - > > I am also concerned about people starting to use these enums and then > > complain if we change them in future. Even though we haven't documented it > > as a public api, people might start using them. So keeping the > > functionality we promise through methods here to minimal is safer.
Use the method in below comments to track HiveStatement status. > On Sept. 18, 2014, 8:07 a.m., Thejas Nair wrote: > > jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java, line 247 > > <https://reviews.apache.org/r/25575/diff/4/?file=693372#file693372line247> > > > > set isRunning=true here and set isRunning=false in other place of other > > calls to setQueryStatus Use the method in below comments to track HiveStatement status. - Dong ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25575/#review53809 ----------------------------------------------------------- On Sept. 24, 2014, 9:17 a.m., Dong Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25575/ > ----------------------------------------------------------- > > (Updated Sept. 24, 2014, 9:17 a.m.) > > > Review request for hive. > > > Repository: hive-git > > > Description > ------- > > When executing query in Beeline, user should have a option to see the > progress through the outputs. Beeline could use the API introduced in > HIVE-4629 to get and display the logs to the client. > > > Diffs > ----- > > beeline/pom.xml 45fa02b > beeline/src/java/org/apache/hive/beeline/Commands.java a92d69f > > itests/hive-unit/src/test/java/org/apache/hive/beeline/TestBeeLineWithArgs.java > 1e66542 > itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java > daf8e9e > jdbc/src/java/org/apache/hive/jdbc/ClosedOrCancelledStatementException.java > PRE-CREATION > jdbc/src/java/org/apache/hive/jdbc/HiveQueryResultSet.java 86bc580 > jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java 2cbf58c > > Diff: https://reviews.apache.org/r/25575/diff/ > > > Testing > ------- > > UT passed. > > > Thanks, > > Dong Chen > >
