----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25575/#review53789 -----------------------------------------------------------
beeline/src/java/org/apache/hive/beeline/Commands.java <https://reviews.apache.org/r/25575/#comment93592> It is safer to also set logThread.setDaemon(true) beeline/src/java/org/apache/hive/beeline/Commands.java <https://reviews.apache.org/r/25575/#comment93591> Lets print debug instead of error here. It would be good to keep beeline usable with other jdbc drivers as well. jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java <https://reviews.apache.org/r/25575/#comment93622> I think we need a public method in HiveStatement for use by other custom 'jdbc' applications. I think the interface of the function should be - public List<String> getQueryLog(boolean incremental, int fetchSize). Can you change this function to get fetchSize as argument ? And also change javadoc of this method to say that this method is a public api (for use outside of hive), but other methods in the class that are not part of java.sql.Statement are considered internal hive apis. - Thejas Nair On Sept. 18, 2014, 6:30 a.m., Dong Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25575/ > ----------------------------------------------------------- > > (Updated Sept. 18, 2014, 6:30 a.m.) > > > Review request for hive. > > > Repository: hive-git > > > Description > ------- > > When executing query in Beeline, user should have a option to see the > progress through the outputs. Beeline could use the API introduced in > HIVE-4629 to get and display the logs to the client. > > > Diffs > ----- > > beeline/pom.xml 45fa02b > beeline/src/java/org/apache/hive/beeline/Commands.java a92d69f > > itests/hive-unit/src/test/java/org/apache/hive/beeline/TestBeeLineWithArgs.java > e1d44ec > itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java > ae128a9 > jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java 2cbf58c > > Diff: https://reviews.apache.org/r/25575/diff/ > > > Testing > ------- > > UT passed. > > > Thanks, > > Dong Chen > >
