Hi All, The change has been implemented with [1]. The milestones will now be removed when merging a PR.
Cheers, Hans [1] https://github.com/apache/hop/pull/3950 On 8 May 2024 at 10:51 +0200, Hans Van Akelyen <hans.van.akel...@gmail.com>, wrote: > Hi all, > > I see no objections, so I will be moving forward with this. > > Cheers, > Hans > On 7 May 2024 at 08:16 +0200, Bart Maertens <bart.maert...@know.bi>, wrote: > > having milestones on issues seems more important than having them on PRs. > > thanks for taking the time to dig into this, Hans! > > > > > > On Mon, May 6, 2024 at 10:37 AM <hans.van.akel...@gmail.com> wrote: > > > > > Hi All, > > > > > > A while back I improved our GH Actions a bit to automatically add the > > > milestone to a GH Issue when using the .take-issue option. > > > At that point in time I also thought it was a good idea to do this on our > > > PR's so we could easily identify which PR's were getting merged for a > > > milestone. > > > > > > Unfortunately it seems doing this is skewing our solved/closed tickets > > > [1]. I have taken a look at some other projects under the ASF umbrella and > > > it seems most of them are not tagging PR's with a milestone. I would like > > > to revert this change (and even change the action to remove a milestone if > > > one was attached during PR creation). I feel this will give us the best > > > representation of the actual work done. > > > > > > Let me know what you think. > > > > > > Cheers, > > > Hans > > > > > > [1] https://github.com/apache/hop/issues?q=is%3Aclosed+milestone%3A2.9 > > >
