On 18 Apr 2002, Jeff Trawick wrote:

> > 1) The MMAP bucket cleanup problem, which has been responsible for
> >    some (rare-ish) segv's on daedalus [I think I figured out
> >    how to fix this last night]
>
> great!

UGGGGHHHHHH It's even MORE complicated than I could have imagined.  It's
quite difficult (it might even be impossible) to ensure that you never
touch m->mmap after it's cleaned up.  You can register your own cleanup,
but what if the apr_mmap_t is dup'ed and ownership is transferred?  Then
you're screwed.

May I just say that cleanups are a bitch.  :)

Anyway, it looks like we might have no choice but to go back to NOT
calling apr_mmap_delete() from mmap_bucket_destroy().  But that means
that due to file_read morphing itself we could potentially have a large
amount of data mmaped at a time before any of it goes away.  Is that
killer?  Because if I could just remove that one line this would all go
away.  =-]

--Cliff


--------------------------------------------------------------
   Cliff Woolley
   [EMAIL PROTECTED]
   Charlottesville, VA


Reply via email to