On Wed, Apr 04, 2007 at 04:30:31PM +0100, Nick Kew wrote:
> Hmmm, I have some recollection of debating this before,

Yes, in the comments of the bug the OP linked.

> presumably without reaching any consensus for change.

Well no-one's refuted (or replied to in any fashion) my last posts in 
bugzilla.

> > -            if (conf->error_override == 0 ||
> > ap_is_HTTP_SUCCESS(r->status)) {
> > +            if (conf->error_override == 0 ||
> > ap_is_HTTP_SUCCESS(r->status) || ap_is_HTTP_REDIRECT(r->status)) {
> 
> I don't think we could accept that, because it breaks existing
> behaviour someone might be relying on.

Behaviour *has already been broken* from 2.0.x to 2.2.x - I've given 
evidence of this. Our work systems heavily rely on the 2.0 behaviour. 
Maybe someone else would like to repeat my tests - it's possible 
it's not as simple as I think. Checking the 1.3.x behaviour would be 
interesting too.

Without any evidence to the contrary though, I'd really appeal for the 
patch to be applied.

Whatever happens, the documentation should be clarified. But to my mind 
there is no doubt that I would not expect a redirect (or Not Modified 
for that matter) to be considered an error.

Cheers

-- 
Stuart

Reply via email to