On Sep 7, 2007, at 5:37 AM, Martin Kraemer wrote:

On Fri, Sep 07, 2007 at 10:30:13AM +0200, jean-frederic clere wrote:
That is going to break:
In mod_proxy.h:
int ap_proxy_lb_workers(void);
In server/scoreboard.c:
+++
static APR_OPTIONAL_FN_TYPE(ap_proxy_lb_workers)
                                *proxy_lb_workers;
+++

Yes, it breaks:

scoreboard.c: In function `ap_calc_scoreboard_size':
scoreboard.c:108: sizeof applied to an incomplete type
scoreboard.c: In function `ap_init_scoreboard':
scoreboard.c:134: sizeof applied to an incomplete type
scoreboard.c: In function `ap_create_scoreboard':
scoreboard.c:286: sizeof applied to an incomplete type
scoreboard.c: In function `ap_get_scoreboard_lb':
scoreboard.c:496: arithmetic on pointer to an incomplete type
scoreboard.c:496: dereferencing pointer to incomplete type


I reverted the patch. I will likely create a proxy_common.h
(or some other name) that includes the various struct defines,
etc which allows scoreboard.h to include that, but also allows
mod_proxy.h to include it as well (so include mod_proxy.h
will work as before).

Reply via email to