Plüm wrote: > >> -----Ursprüngliche Nachricht----- >> Von: jean-frederic clere >> Gesendet: Montag, 10. September 2007 16:38 >> An: [email protected] >> Betreff: Re: svn commit: r573264 - >> /httpd/httpd/trunk/include/scoreboard.h >> >> >> Jim Jagielski wrote: >>> On Sep 10, 2007, at 6:37 AM, Plüm, Rüdiger, VF-Group wrote: >>> >>>>> For example what about adding: >>>>> static APR_OPTIONAL_FN_TYPE(ap_proxy_lb_worker_size) >>>>> *proxy_lb_worker_size; >>>>> and use a void * in scoreboard and an int for the size? >>>> For me this sounds fine, but I would guess that Jim doesn't like >>>> the void * idea in the scoreboard. >>>> >>> I don't mind it at all, if we use it because we don't know >>> what will be stored away or because we may use the storage >>> differently at different times. But this is never the >>> case. lb_score always is proxy_worker_stat. >>> >>> >> The attached patch remove "lb_score" from scoreboard.c. >> >> Comments? > > 1. IMHO requires a minor bump.
Yes. > 2. Why messing around with lb_score any longer? Instead of > > return sizeof(lb_score); > > we could do > > return sizeof(proxy_worker_stat); Sure. > > 3. We should register the optional functions ap_proxy_lb_workers and > ap_proxy_lb_worker_size in the same place and should keep the code > of them next to each other. With your patch they are distributed over > mod_proxy.c and mod_proxy_balancer.c. Well that just because I am thinking that the size of proxy_worker_stat could be "changed" by a balancer, like adding extra bytes to proxy_worker_stat. > IMHO they belong to mod_proxy.c > as we call ap_proxy_initialize_worker_share from mod_proxy's child init > (so even if we do not load mod_proxy_balancer we need the scoreboard > entries). > 4. All > if (lb_limit) > in scoreboard.c should be extended to > if (lb_limit && worker_size) Right. Cheers Jean-Frederic > > > Regards > > Rüdiger > >
