On Wed, 9 Jan 2008 11:15:57 +0100 Plüm, Rüdiger, VF-Group <[EMAIL PROTECTED]> wrote:
> > At lines 364 and 460 (trunk), you set HTTP_SERVICE_UNAVAILABLE > > when broken chunking is encountered. I don't think that's right: > > That's because this was the error code that was used there before for > empty chunk size lines, but I agree that this error code might be > wrong. > > > > > - bad chunking in a request should return HTTP_BAD_REQUEST > > - bad chunking in a proxy response should return HTTP_BAD_GATEWAY > > > > Can we know if we're processing request or response at this point? > > IMHO unfortunately not, but it does not matter in the proxy case > anyway, because the error messages sent via bail_out_on_error are > sent to the backend server in this case and not the client :-). This > is because we have switched the meaning of INPUT and OUTPUT filters > for our proxy connection to the backend. The client will receive > internal server error just as with your test with the insane sized > chunk extension. This is no regression it has worked forever like > this. So in the light of this it might make sense to change this > simply from HTTP_SERVICE_UNAVAILABLE to HTTP_BAD_REQUEST. WDYT? Not so sure here - we're not really returning an error status in any case, and sending errors to the backend falls outside the scope of HTTP. I've just voted +1 on keeping that as-is, in the hope of getting backported in time for Jim's 2.2.8 schedule. > > Also, I committed a simple edge-case fix against empty data > > buckets getting in the way of detecting a lineend. > > I presume you're OK with r610240? > > Thanks. Your patch is much better than my stupid one. Or in other words a trivial improvement on yours. But I added it to the backport proposal in STATUS. -- Nick Kew Application Development with Apache - the Apache Modules Book http://www.apachetutor.org/
