On Jan 9, 2008, at 9:59 AM, Jim Jagielski wrote:


On Jan 9, 2008, at 9:42 AM, Nick Kew wrote:
Not so sure here - we're not really returning an error status in
any case, and sending errors to the backend falls outside the scope
of HTTP.

I've just voted +1 on keeping that as-is, in the hope of getting
backported in time for Jim's 2.2.8 schedule.

Reviewing and testing http://people.apache.org/~niq/ chunk_optimization.diff
as we speak... I'd also like this in 2.2.8...


In the case where we have nothing but zero-length data buckets
in the brigade, we leveraging that when we leave the
loop, we'll be at a sentinel. Even so, any issues with
the small "can't happen" check below?

    /* We had no data in this brigade */
    if (!len || e == APR_BRIGADE_SENTINEL(b)) {
        return APR_EAGAIN;
    }

Reply via email to