> Am 30.06.2016 um 17:55 schrieb Yann Ylavic <ylavic....@gmail.com>: > > On Thu, Jun 30, 2016 at 5:38 PM, Stefan Eissing > <stefan.eiss...@greenbytes.de> wrote: >> We now set exactly the same callback right before in line 709. If we had >> more than one callback, we would not have to specify NULL, but restore any >> previous callback there was, right? > > Actually NULL preserves the current callback, so once we've set one > (or the default) at global/connection init time, if we use NULL > everywhere else we can preserve it (patch proposed in my previous > message).
What I meant was: we would need to reset the callback that was in place before line 709. The "NULL=ignore the parameter" will not suffice in case we have more than one callback. I have not digested the patch completely, but fully agree that changing things should be delayed until the time we actually have decided to go for it. -Stefan PS. JFTR, the NULL handling here is whacky by OpenSSL. But, of course, it is what it is...