On Fri, Jul 1, 2016 at 1:44 PM, Pietro Paolini <pietro.paol...@ocado.com> wrote:
>
> On 1 July 2016 at 11:18, Pietro Paolini <pietro.paol...@ocado.com> wrote:
>>
>> Is it correct ? It does not look good to me.
>>
>>  -    while ((status = apr_getopt(opt,
>> "n:c:t:s:b:T:p:u:v:lrkVhwix:y:z:C:H:P:A:g:X:de:SqB:m:"
>> +    while ((status = apr_getopt(opt,
>> "n:c:t:s:b:T:p:u:v:lrkVhwixI:y:z:C:H:P:A:g:X:de:SqB:m:"
>>
>> The x option has lost its argument, the new option you have introduced
>> uses an argument but the :
>>
>> +    fprintf(stderr, "    -I Use TLS Server Name Indication (SNI)
>> extension\n");
>>
>> Does not tell that.

Right, it was fixed in a follow up (http://svn.apache.org/r1750855).

>
> That will do the job, as it stands right now it will be working if given a
> -I option with a random argument, for example :
>
> ./support/ab -I randomstring  -c 1 -n 1 https://whatever/url
>
> The I argument is actually not used.

The -I does not take any argument, it tells ab to use iether the -H
"Host: ..." if any, or the host from the given URL otherwise.

Regards,
Yann.

Reply via email to