On Thu, Jan 19, 2017 at 10:58 PM, Yann Ylavic <ylavic....@gmail.com> wrote: > On Thu, Jan 19, 2017 at 10:41 PM, Stefan Eissing > <stefan.eiss...@greenbytes.de> wrote: >>> >>> We really need to not destroy m->pool in its parent's cleanup. >> >> Hmm, why is that bad? > > If the parent pool cleanup is called, that pool is being destroyed, > which also destroys all its children pools (for each parent's child, > apr_pool_destroy(child) is called by apr_pool_destroy(parent), > implicitely). > > Here that's a pre_cleanup of session->pool (parent), so mplx->pool > (child) will be destroyed after, but in any case child->pool is to be > destroyed, you can't avoid that.
Wait! Of course one can destroy children pools in a *pre* cleanup of the parent pool, since they will detach themselves from the parent pool before it starts destroying all its childrens. Not very common (coming soon) but still. That would not work in a "normal" cleanup (children are dead already), but it's not the case here. Sorry for the noise.
