Just for fun, what is the functional difference, if any, between this
very large patch, that adds lots of code, and this extremely simple
diff which, from what I can tell, handles the exact defined
"problem" with the original code???
Just curious if our current policy is to use a sledgehammer now
to fix what can be handled with a pair of tweezers.
diff --git a/modules/proxy/mod_proxy_balancer.c
b/modules/proxy/mod_proxy_balancer.c
index bdefc8f54..21a65910d 100644
--- a/modules/proxy/mod_proxy_balancer.c
+++ b/modules/proxy/mod_proxy_balancer.c
@@ -784,13 +784,12 @@ static int balancer_post_config(apr_pool_t *pconf,
apr_pool_t *plog,
* During create_proxy_config() we created a dummy id. Now that
* we have identifying info, we can create the real id
*/
- id = apr_psprintf(pconf, "%s.%s.%d.%s.%s.%u.%s",
+ id = apr_psprintf(pconf, "%s.%s.%d.%s.%s.%s",
(s->server_scheme ? s->server_scheme : "????"),
(s->server_hostname ? s->server_hostname : "???"),
(int)s->port,
(s->server_admin ? s->server_admin : "??"),
(s->defn_name ? s->defn_name : "?"),
- s->defn_line_number,
(s->error_fname ? s->error_fname :
DEFAULT_ERRORLOG));
conf->id = apr_psprintf(pconf, "p%x",
ap_proxy_hashfunc(id, PROXY_HASHFUNC_DEFAULT));
> On Feb 6, 2018, at 12:59 PM, Yann Ylavic <[email protected]> wrote:
>
> <mod_proxy_lb.diff>
