Re: BalancerMember and RFC1035 compliance - BalancerMember worker hostname (65-character.long.DNS.name.com) too long

[Graham Leggett]

On 07 Feb 2018, at 5:18 PM, Graham Leggett <minf...@sharp.fm> wrote:

> Looking back through the archives, looks like that backport was already 
> accepted:
> 
> http://svn.apache.org/viewvc?view=revision&revision=1634520

Hmmm… it’s actually only solved the URL too long problem, the hostname too long 
problem is still a fatal error:

    ptr = apr_uri_unparse(p, &uri, APR_URI_UNP_REVEALPASSWORD);
    if (PROXY_STRNCPY(wshared->name, ptr) != APR_SUCCESS) {
        ap_log_error(APLOG_MARK, APLOG_ERR, 0, ap_server_conf, APLOGNO(02808)
        "Alert! worker name (%s) too long; truncated to: %s", ptr, wshared->name
);
    }
    if (PROXY_STRNCPY(wshared->scheme, uri.scheme) != APR_SUCCESS) {
        return apr_psprintf(p, "worker scheme (%s) too long", uri.scheme);
    }
    if (PROXY_STRNCPY(wshared->hostname, uri.hostname) != APR_SUCCESS) {
        return apr_psprintf(p, "worker hostname (%s) too long", uri.hostname);
    }

Would this break if we did the same warning on hostname that’s done on the full 
URL?

Regards,
Graham
—

smime.p7s
Description: S/MIME cryptographic signature