Re: BalancerMember and RFC1035 compliance - BalancerMember worker hostname (65-character.long.DNS.name.com) too long

[Graham Leggett]

On 07 Feb 2018, at 5:33 PM, Jim Jagielski <j...@jagunet.com> wrote:

> +1 on removing that as fatal as well... I'll fix trunk and propose
> for backport

Something like this?

Index: modules/proxy/proxy_util.c
===================================================================
--- modules/proxy/proxy_util.c  (revision 1823472)
+++ modules/proxy/proxy_util.c  (working copy)
@@ -1727,7 +1727,8 @@
         return apr_psprintf(p, "worker scheme (%s) too long", uri.scheme);
     }
     if (PROXY_STRNCPY(wshared->hostname, uri.hostname) != APR_SUCCESS) {
-        return apr_psprintf(p, "worker hostname (%s) too long", uri.hostname);
+        ap_log_error(APLOG_MARK, APLOG_ERR, 0, ap_server_conf, APLOGNO()
+        "Alert! worker hostname (%s) too long; truncated to: %s", 
uri.hostname, wshared->hostname);
     }
     wshared->flush_packets = flush_off;
     wshared->flush_wait = PROXY_FLUSH_WAIT;

Regards,
Graham
—

smime.p7s
Description: S/MIME cryptographic signature