Re: svn commit: r1807876 - /httpd/httpd/trunk/modules/proxy/mod_proxy_fcgi.c

[Yann Ylavic]

Hi Luca,

On Sat, Sep 9, 2017 at 12:24 PM,  <elu...@apache.org> wrote:
>
> +            if (((conn->worker->s->flush_packets == flush_on) ||
> +                 ((conn->worker->s->flush_packets == flush_auto) &&
> +                  (apr_poll(flushpoll, 1, &flushpoll_fd,
> +                            conn->worker->s->flush_wait) == APR_TIMEUP))) && 
> mayflush) {

Don't we want to test "mayflush" before anything here, why would we
poll() otherwise?

Thanks,
Yann.