On Thu, Feb 8, 2018 at 8:50 PM, Luca Toscano <[email protected]> wrote: > > 2018-02-08 20:37 GMT+01:00 Yann Ylavic <[email protected]>: >> >> Hi Luca, >> >> On Sat, Sep 9, 2017 at 12:24 PM, <[email protected]> wrote: >> > >> > + if (((conn->worker->s->flush_packets == flush_on) || >> > + ((conn->worker->s->flush_packets == flush_auto) && >> > + (apr_poll(flushpoll, 1, &flushpoll_fd, >> > + conn->worker->s->flush_wait) == >> > APR_TIMEUP))) && mayflush) { >> >> Don't we want to test "mayflush" before anything here, why would we >> poll() otherwise? > > > it makes a lot of sense, +1 > > If you want to commit please go ahead :)
Not really, since it's part of a patch series you may want to follow up on it ;)
