Hi Yann,

2018-02-08 20:37 GMT+01:00 Yann Ylavic <ylavic....@gmail.com>:

> Hi Luca,
>
> On Sat, Sep 9, 2017 at 12:24 PM,  <elu...@apache.org> wrote:
> >
> > +            if (((conn->worker->s->flush_packets == flush_on) ||
> > +                 ((conn->worker->s->flush_packets == flush_auto) &&
> > +                  (apr_poll(flushpoll, 1, &flushpoll_fd,
> > +                            conn->worker->s->flush_wait) ==
> APR_TIMEUP))) && mayflush) {
>
> Don't we want to test "mayflush" before anything here, why would we
> poll() otherwise?
>

it makes a lot of sense, +1

If you want to commit please go ahead :)

Luca

Reply via email to