Thanks Thomas and Luciano for guiding us on the best practices. These are great feedback and suggestions. We will incorporate them as part of working towards the first release. Balaji.V
Sent from Yahoo Mail for iPhone On Saturday, September 21, 2019, 5:11 PM, Thomas Weise <[email protected]> wrote: Please check your rat configuration. It excludes too many files. I would recommend to make it very specific and have such issues highlighted early in the CI. It is also possible to automate license header generation, besides just checking it. Here is one example: https://github.com/apache/apex-core/blob/master/pom.xml#L152 Similar tools are available for enforcing consistent code formatting. Beam uses spotless. Once you start using it, you don't want to go back to manually fixing code style issues :) Generally, try automating as much as possible and let CI be the guard. While working through this, I would suggest to compile the release guide and add it to the website. Thanks, Thomas On Sat, Sep 21, 2019 at 4:54 PM Vinoth Chandar <[email protected]> wrote: > Good catch Luciano. The jar was a facepalm moment. I remember > vividly removing that (code does not use it anymore). Not sure what > happened there.. > > We will go over the others issues and may be script the checks as well, if > possible. > > > On Sat, Sep 21, 2019 at 1:48 PM [email protected] <[email protected]> > wrote: > > > Thanks everyone for the help in validating the release. Let's close this > > voting thread. I will create a new release candidate after addressing the > > compliancy concerns. > > Balaji.V > > On Friday, September 20, 2019, 03:47:56 PM PDT, Luciano Resende < > > [email protected]> wrote: > > > > Based on the current DISCLAIMER I am assuming fully compliant release. > > > > -1 (binding) > > > > Signatures ok, > > > > the source distribution contains a binary jar which is not allowed > > ./hudi-cli/lib/dnl/utils/textutils/0.3.3/textutils-0.3.3.jar > > > > Missing headers: > > !????? ./README.md > > !????? ./RELEASE_NOTES.md > > !????? ./docker/hoodie/hadoop/prestobase/Dockerfile > > !????? ./packaging/README.md > > > > Your notice has too many unnecessary mentions, please see the guide here > > http://www.apache.org/dev/licensing-howto.html > > > > Also, you should not add the additional lines such as > > "Licensed under the Apache License, Version 2.0 (the "License"); you > > may not use this file except in compliance with the License. You may > > obtain a copy of the License at" > > > > " Unless required by applicable law or agreed to in writing, software > > distributed under the License is distributed on an "AS IS" BASIS, > > WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or > > implied. See the License for the specific language governing > > permissions and limitations under the License." > > > > these are already built into the license, and properly worded. > > > > > > On Tue, Sep 17, 2019 at 5:02 PM [email protected] <[email protected]> > > wrote: > > > > > > Hi everyone,We have a new release candidate after addressing issues > > reported in first release candidate (see email thread)The new version is > : > > 0.5.0-incubating-rc2. Please review and vote on the release candidate #2 > > for version 0.5.0, as follows: > > > [ ] +1, Approve the release[ ] -1, Do not approve the release (please > > provide specific comments)The complete staging area is available for your > > review, which includes: > > > - JIRA release notes [1] > > > - The official Apache source release and binary convenience releases > > to be deployed to dist.apache.org [2], which are signed with the key > with > > fingerprint AF9BAF79D311A3D3288E583F24A499037262AAA4 [3], > > > > > > - all artifacts to be deployed to the Maven Central Repository [4] > > > > > > - source code tag "release-0.5.0-incubating-rc2" [5] > > > > > > The vote will be open for at least 72 hours. > > > Please cast your votes before *Sep. 20 2019, 21:00 UTC*. > > > > > > It is adopted by majority approval, with at least 3 PMC affirmative > > votes. > > > - > > > https://jira.apache.org/jira/secure/ReleaseNote.jspa?projectId=12322822&version=12346087 > > > - > > > https://dist.apache.org/repos/dist/dev/incubator/hudi/hudi-0.5.0-incubating-rc2/ > > > - https://dist.apache.org/repos/dist/release/incubator/hudi/KEYS > > > - > > https://repository.apache.org/content/repositories/orgapachehudi-1002/ > > > - > > > https://github.com/apache/incubator-hudi/tree/release-0.5.0-incubating-rc2 > > > > > > > > > P.S. : As this is a first time where Hudi community will be performing > > release voting, you can look at > > > https://lists.apache.org/thread.html/75e40ed5a6e0c3174728a0bcfe86cbcd99ae4778ebe94b839f0674cd@%3Cdev.flink.apache.org%3E > > for some understanding of validations community does to cast their > > votes.Thanks,Balaji.V > > > > > > > > -- > > Luciano Resende > > http://twitter.com/lresende1975 > > http://lresende.blogspot.com/ >
