Sorry, I mistakenly assumed that this RC had fixes for the previously discussed issues.
-- sent from mobile On Mon, Sep 30, 2019, 10:06 AM [email protected] <[email protected]> wrote: > > Hi Thomas, > Yes, Luciano also referred to this binary issue earlier. We had addressed > the comments (including binary presence, RAT automation and release > automation scripts and basic check) as part of > https://github.com/apache/incubator-hudi/pull/918. Luciano had earlier > reviewed the PR and I have addressed his follow-up comments. We had > requested mentors to help review this PR to see if anything is still > inconsistent. > If there are no other comments on this PR till this afternoon, I will > address any pending comments, create a new RC candidate and will send an > email along with scripted basic validation to help check the new RC > candidate. > I do have a working document that I am making changes to capture release > process. I will be publishing them to a wiki once the first release > candidate is approved. > Balaji.V > > > > > On Monday, September 30, 2019, 08:44:12 AM PDT, Thomas Weise < > [email protected]> wrote: > > The source release contains at least one binary: > > hudi-0.5.0-incubating-rc2 $ find . -name *.jar > ./hudi-cli/lib/dnl/utils/textutils/0.3.3/textutils-0.3.3.jar > > There could be more, this was just the first check run. > > Have you already scripted building the release candidate from clean source > and the basic checks? > Ideally it's done consistently by the release managers and verified as part > of voting. > > > On Thu, Sep 26, 2019 at 2:49 PM Vinoth Chandar <[email protected]> wrote: > > > @mentors Hopefully we are very close. Your eyes on this will > significantly > > help us to get it right! > > > > On Thu, Sep 26, 2019 at 1:42 PM [email protected] <[email protected]> > > wrote: > > > > > > > > Thanks Luciano for the comments. > > > I looked at other projects that are currently incubating to see how > they > > > setup top-level LICENSE and NOTICE files. As you mentioned, these files > > are > > > generated for source release. I have updated HUDI's NOTICE and LICENSE > > > files in the same way. > > > I have also addressed other comments. Please review the changes. > > > Thanks,Balaji.V > > > For Reference, NOTICE and LICENSE in other incubating projects > > > 1. https://github.com/apache/incubator-gobblin/blob/master/LICENSE > > > 2. https://github.com/apache/incubator-gobblin/blob/master/NOTICE > > > 3. https://github.com/apache/incubator-heron/blob/master/LICENSE > > > 4. https://github.com/apache/incubator-heron/blob/master/NOTICE > > > > > > On Tuesday, September 24, 2019, 06:54:29 AM PDT, Luciano Resende < > > > [email protected]> wrote: > > > > > > I will look into this and get back to you tonight. > > > > > > On Mon, Sep 23, 2019 at 10:30 [email protected] <[email protected]> > > > wrote: > > > > > > > Hi Luciano, > > > > I went through the licensing link you provided and have addressed all > > the > > > > comments in this PR : > > https://github.com/apache/incubator-hudi/pull/918 > > > > I have described the steps I used to generate the final NOTICE file. > > Can > > > > you please review this PR and see if it makes sense. > > > > > > > > Thanks,Balaji.V > > > > On Friday, September 20, 2019, 03:47:56 PM PDT, Luciano Resende < > > > > [email protected]> wrote: > > > > > > > > Based on the current DISCLAIMER I am assuming fully compliant > release. > > > > > > > > -1 (binding) > > > > > > > > Signatures ok, > > > > > > > > the source distribution contains a binary jar which is not allowed > > > > ./hudi-cli/lib/dnl/utils/textutils/0.3.3/textutils-0.3.3.jar > > > > > > > > Missing headers: > > > > !????? ./README.md > > > > !????? ./RELEASE_NOTES.md > > > > !????? ./docker/hoodie/hadoop/prestobase/Dockerfile > > > > !????? ./packaging/README.md > > > > > > > > Your notice has too many unnecessary mentions, please see the guide > > here > > > > http://www.apache.org/dev/licensing-howto.html > > > > > > > > Also, you should not add the additional lines such as > > > > "Licensed under the Apache License, Version 2.0 (the "License"); you > > > > may not use this file except in compliance with the License. You may > > > > obtain a copy of the License at" > > > > > > > > " Unless required by applicable law or agreed to in writing, software > > > > distributed under the License is distributed on an "AS IS" BASIS, > > > > WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or > > > > implied. See the License for the specific language governing > > > > permissions and limitations under the License." > > > > > > > > these are already built into the license, and properly worded. > > > > > > > > > > > > On Tue, Sep 17, 2019 at 5:02 PM [email protected] < > [email protected] > > > > > > > wrote: > > > > > > > > > > Hi everyone,We have a new release candidate after addressing issues > > > > reported in first release candidate (see email thread)The new version > > is > > > : > > > > 0.5.0-incubating-rc2. Please review and vote on the release candidate > > #2 > > > > for version 0.5.0, as follows: > > > > > [ ] +1, Approve the release[ ] -1, Do not approve the release > (please > > > > provide specific comments)The complete staging area is available for > > your > > > > review, which includes: > > > > > - JIRA release notes [1] > > > > > - The official Apache source release and binary convenience > > releases > > > > to be deployed to dist.apache.org [2], which are signed with the key > > > with > > > > fingerprint AF9BAF79D311A3D3288E583F24A499037262AAA4 [3], > > > > > > > > > > - all artifacts to be deployed to the Maven Central Repository > [4] > > > > > > > > > > - source code tag "release-0.5.0-incubating-rc2" [5] > > > > > > > > > > The vote will be open for at least 72 hours. > > > > > Please cast your votes before *Sep. 20 2019, 21:00 UTC*. > > > > > > > > > > It is adopted by majority approval, with at least 3 PMC affirmative > > > > votes. > > > > > - > > > > > > > > > > https://jira.apache.org/jira/secure/ReleaseNote.jspa?projectId=12322822&version=12346087 > > > > > - > > > > > > > > > > https://dist.apache.org/repos/dist/dev/incubator/hudi/hudi-0.5.0-incubating-rc2/ > > > > > - > https://dist.apache.org/repos/dist/release/incubator/hudi/KEYS > > > > > - > > > > > https://repository.apache.org/content/repositories/orgapachehudi-1002/ > > > > > - > > > > > > > > > > https://github.com/apache/incubator-hudi/tree/release-0.5.0-incubating-rc2 > > > > > > > > > > > > > > > P.S. : As this is a first time where Hudi community will be > > performing > > > > release voting, you can look at > > > > > > > > > > https://lists.apache.org/thread.html/75e40ed5a6e0c3174728a0bcfe86cbcd99ae4778ebe94b839f0674cd@%3Cdev.flink.apache.org%3E > > > > for some understanding of validations community does to cast their > > > > votes.Thanks,Balaji.V > > > > > > > > > > > > > > > > -- > > > > Luciano Resende > > > > http://twitter.com/lresende1975 > > > > http://lresende.blogspot.com/ > > > > > > -- > > > Sent from my Mobile device > > > > > >
