Thanks for the update, vino! here's the -1 vote feedback for everyone's context..
As you bundled several ASF projects that have NOTICE files, their NOTICE > files need to be examined and parts added to your NOTICE file. [1] > License is missing information fo this file copyright Twitter [3] > Perhaps you should consider using the work in progress disclaimer. [2] > Thanks, > Justin > 1. http://www.apache.org/dev/licensing-howto.html#alv2-dep > 2. > https://incubator.apache.org/policy/incubation.html#work_in_progress_disclaimer >>We may need to revert HUDI-676[3]: Address issues towards removing use of WIP Disclaimer I think we should address the feedback and ensure VOTE passed with "non WIP" disclaimer.. the WIP disclaimer cannot be retained forever and needs to be fixed before graduation IIUC. >>As you bundled several ASF projects that have NOTICE files, Again, we are back to binary vs source releases.. the source releases we make DO NOT bundle anything.. So we should not have to add anything to NOTICE. The same link mentioned, also states, "dont include stuff unnecessarily" (not a quote). Does maven jars count as binary distribution of software? I suggest we file a LEGAL issue, get it stamped by the right folks and do that. This can be a good strategy, in addition to looking at other projects. On Wed, Mar 18, 2020 at 3:27 AM vino yang <[email protected]> wrote: > Hi all, > > We encountered some issues while voting RC1 on general@[1], so we canceled > the vote for rc1. The blocker issues we are currently addressing are: > > * HUDI-720: NOTICE file needs to add more content based on the NOTICE files > of the ASF projects that hudi bundles(I have opened a PR[2] to fix it) > * We may need to revert HUDI-676[3]: Address issues towards removing use of > WIP Disclaimer > > I will prepare 0.5.2 RC2 ASAP after fixing them. Please be patient. > > Best, > Vino > > [1]: > > http://mail-archives.apache.org/mod_mbox/incubator-general/202003.mbox/%3C932F44A0-1CEE-4549-896B-70FB61EAA034%40classsoftware.com%3E > [2]: https://github.com/apache/incubator-hudi/pull/1417 > [3]: https://github.com/apache/incubator-hudi/pull/1386 >
