What about FULL_SYNC SYNC -> default BACKGROUND NODE ? On Fri, Feb 16, 2018 at 3:09 PM, Ivan Rakov <ivan.glu...@gmail.com> wrote:
> From my point of view, STRICT is the best option. The name signalizes to > user that this mode provides optional strict guarantees. > FULL_SYNC can be messed with CacheWriteSynchronizationMode#FULL_SYNC. I > don't like the idea of naming different things with same names. > > Best Regards, > Ivan Rakov > > > On 16.02.2018 15:01, Dmitriy Setrakyan wrote: > >> BTW, Ilya, why not name the enum value FULL_SYNC instead of STRICT? >> >> On Fri, Feb 16, 2018 at 5:43 AM, Dmitriy Setrakyan <dsetrak...@apache.org >> > >> wrote: >> >> Naming one of the enum constants DEFAULT was a huge mistake. Not sure how >>> it passed a code review, but let us all be more careful going forward. >>> >>> I agree with Ilya. The only remedy right now is to deprecate the DEFAULT >>> constant. >>> >>> D. >>> >>> On Fri, Feb 16, 2018 at 5:37 AM, Ilya Lantukh <ilant...@gridgain.com> >>> wrote: >>> >>> Hi all, >>>> >>>> I'd like to suggest to change default WALMode. Currently we have: >>>> DEFAULT (write and fsync), >>>> LOG_ONLY (write without fsync), >>>> BACKGROUND, >>>> NONE. >>>> >>>> It turns out that fsyncs in current DEFAULT mode significantly restricts >>>> Ignite performance. Compared to LOG_ONLY, it offers additional >>>> guarantees >>>> that data won't be lost in case of OS or hardware failure, but such >>>> guarantees aren't needed very often, and tradeoff is too big. >>>> >>>> I suggest to rename current DEFAULT to STRICT and make LOG_ONLY new >>>> default >>>> mode. We can leave DEFAULT as @Deprecated and treat it as STRICT, so >>>> that >>>> users with old configs will have the same behaviour. >>>> >>>> What do you think? >>>> >>>> On Fri, Feb 16, 2018 at 12:35 AM, Denis Magda <dma...@apache.org> >>>> wrote: >>>> >>>> Vladimir, >>>>> >>>>> I would suggest not to do this because we still need to spend time on >>>>> testing, documentation, etc. If someone shows interest in this features >>>>> they can assemble binaries from the master. >>>>> >>>>> -- >>>>> Denis >>>>> >>>>> On Thu, Feb 15, 2018 at 6:43 AM, Nikolay Izhikov <nizhi...@apache.org> >>>>> wrote: >>>>> >>>>> +1 >>>>>> >>>>>> В Чт, 15/02/2018 в 17:27 +0300, Vladimir Ozerov пишет: >>>>>> >>>>>>> Igniters, >>>>>>> >>>>>>> AI 2.4 release was shifted a bit and over this time we implemented >>>>>>> >>>>>> two >>>> >>>>> important SQL features: >>>>>>> 1) COPY command for fast file upload to the cluster [1] >>>>>>> 2) Streaming mode for thin driver [2] >>>>>>> >>>>>>> Both commands are very important for fast data ingestion into Ignite >>>>>>> through SQL. I would like to ask community to consider to include >>>>>>> >>>>>> these >>>> >>>>> two >>>>>> >>>>>>> features into AI 2.4 in *experimental* state because both of them >>>>>>> >>>>>> will >>>> >>>>> be >>>>> >>>>>> improved in various ways in the nearest time. If we do so, we will >>>>>>> >>>>>> be >>>> >>>>> able >>>>>> >>>>>>> to collect some feedback from the users before AI 2.5 release. What >>>>>>> >>>>>> do >>>> >>>>> you >>>>>> >>>>>>> think? >>>>>>> >>>>>>> Vladimir. >>>>>>> >>>>>>> [1] https://issues.apache.org/jira/browse/IGNITE-6917 >>>>>>> [2] https://issues.apache.org/jira/browse/IGNITE-7253 >>>>>>> >>>>>>> On Tue, Feb 13, 2018 at 1:22 AM, Dmitriy Setrakyan < >>>>>>> >>>>>> dsetrak...@apache.org> >>>>>> >>>>>>> wrote: >>>>>>> >>>>>>> On Mon, Feb 12, 2018 at 9:22 AM, Dmitry Pavlov < >>>>>>>> >>>>>>> dpavlov....@gmail.com> >>>>> >>>>>> wrote: >>>>>>>> >>>>>>>> Hi, >>>>>>>>> >>>>>>>>> Unfortunately, a quick fix did not give us too much performance >>>>>>>>> >>>>>>>> boost. >>>>>> >>>>>>> I'm going to implement a complete algorithm change for storing >>>>>>>>> >>>>>>>> the >>>> >>>>> page >>>>>> >>>>>>> identifier. But this change is quite significant and will >>>>>>>>> >>>>>>>> require >>>> >>>>> re-testing. I suggest including >>>>>>>>> https://issues.apache.org/jira/browse/IGNITE-7638 in the next >>>>>>>>> >>>>>>>> version, >>>>>> >>>>>>> for >>>>>>>> >>>>>>>>> example, to 2.5. >>>>>>>>> >>>>>>>>> Sincerely, >>>>>>>>> Dmitriy Pavlov >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> Dmitriy, thanks for the update! Are there other tickets that are >>>>>>>> >>>>>>> holding >>>>>> >>>>>>> the release at this point? I remember that there was a performance >>>>>>>> degradation issue in FULL_SYNC mode, but I cannot find a ticket. >>>>>>>> >>>>>>>> D. >>>>>>>> >>>>>>>> >>>> >>>> -- >>>> Best regards, >>>> Ilya >>>> >>>> >>> >
