Hi Denis, Ivan As discussed I have updated the PR and incorporated review comments.
https://github.com/apache/ignite/pull/6490/files Please take a look and share your feedback. Regard, Saikat On Sat, Aug 10, 2019 at 5:51 PM Saikat Maitra <saikat.mai...@gmail.com> wrote: > Hello Denis, Ivan > > Yes, I can take up the changes for IGNITE-7825. > > I had a doubt on the usage of the Default Query Timeout. > > I had raised the PR in an assumption that Default Query Timeout will only > be used if user had not provided Cache Query Timeout > > https://github.com/apache/ignite/pull/6490/files > > I wanted to discuss if it is correct intended usage of Default Query > Timeout or should we reconsider? > > Regards, > Saikat > > > > On Fri, Aug 9, 2019 at 12:11 PM Denis Magda <dma...@apache.org> wrote: > >> Ivan, thanks for sharing this discussion. Let's use it for our >> conversation. >> >> - >> Denis >> >> >> On Thu, Aug 8, 2019 at 11:15 PM Павлухин Иван <vololo...@gmail.com> >> wrote: >> >> > Just for the protocol. There was an original dev-list discussion [1]. >> > Added a link to the ticket as well. >> > >> > [1] >> > >> http://apache-ignite-developers.2346864.n4.nabble.com/IGNITE-7285-Add-default-query-timeout-td41828.html >> > >> > пт, 9 авг. 2019 г. в 01:22, Denis Magda <dma...@apache.org>: >> > > >> > > Hey Saikat, >> > > >> > > Are you still working on this ticket? >> > > https://issues.apache.org/jira/browse/IGNITE-7285 >> > > >> > > Seems that's the last API that doesn't support timeouts - JDBC and >> ODBC >> > > drivers already go with it. >> > > >> > > If you don't have time to complete the changes then someone else from >> the >> > > community can take over. We see a lot of demand for this API and here >> is >> > > one example: >> > > >> > >> https://stackoverflow.com/questions/57275301/how-to-set-a-query-timeout-for-apache-ignite-cache >> > > >> > > - >> > > Denis >> > >> > >> > >> > -- >> > Best regards, >> > Ivan Pavlukhin >> > >> >
